Make sure form end buttons grow together #5944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd seen some flakes around the app not being relaunched by killAndReopenApp and looking at the videos, it seemed like the app simply never reappeared. Using ActivityScenario instead of launching directly seems to reduce the flakes.
| app:icon="@drawable/ic_send_24" | ||
| app:iconGravity="textStart" /> | ||
| </androidx.constraintlayout.widget.ConstraintLayout> | ||
| app:layout_goneMarginStart="0dp" /> |
There was a problem hiding this comment.
I think this might not work as expected now as it's no longer ConstraintLayout. So if the first button is gone (because of the settings) there will be a margin visible.
There was a problem hiding this comment.
Ach! So annoying that we can't have two views match heights like this in ConstraintLayout I looked into it again and it seems like there still isn't a way (although so SOs have out of date answers). I've used LinearLayout's dividers to achieve the same thing as the goneMargin attributes.
grzesiek2010
approved these changes
Feb 1, 2024
|
Tested with Success! Verified on device with Android 8.1,10 Verified cases:
|
|
Tested with Success! Verified on device with Android 13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5942
I also made a change to
killAndReopenAppas I ran into some flakes while running checks.Why is this the best possible solution? Were any other approaches considered?
I used the same solution here that we used for the bottom selection controls on other screens. As far as I can remember, we don't think there's a way to get two elements to grow width/heigh in sync using
ConstraintLayout.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This is really low risk. Probably enough to make sure the bug is fixed!
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still pass