Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct icon used in delete button #6210

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Correct icon used in delete button #6210

merged 1 commit into from
Jun 20, 2024

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Jun 19, 2024

Closes #6209

Why is this the best possible solution? Were any other approaches considered?

Nothing to discuss here really! I just replaced the icon.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Worth checking the icon is correct, but other than that nothing has changed.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review June 19, 2024 10:04
@seadowg seadowg requested a review from lognaturel June 19, 2024 10:04
@srujner
Copy link

srujner commented Jun 20, 2024

Tested with Success!
Verified on device with Android 13

Verified cases:

@dbemke
Copy link

dbemke commented Jun 20, 2024

Tested with Success!
Verified on device with Android 10

@seadowg seadowg merged commit 79b02d0 into getodk:master Jun 20, 2024
6 checks passed
@seadowg seadowg deleted the bin-icon branch June 20, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete layer icon is +, should be trashcan
4 participants