Ignore UTF-8 BOM added by some CSV exporters #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
approved these changes
Jul 6, 2022
3 tasks
lognaturel
added a commit
to lognaturel/javarosa
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #687
What has been done to verify that this works as intended?
Tried with a user file that was crashing, added a test.
Why is this the best possible solution? Were any other approaches considered?
I considered manually ignoring the BOM characters but using a library seems a bit cleaner. I don't feel strongly about this one, though.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The one risk I could think of is that UTF-8 characters might be treated differently. I added a test for that. I can't think of additional risks.
Do we need any specific form for testing your changes? If so, please attach one.
bom.zip
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.