Exclude newer version of commons-io used in javarosa #5181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That’s annoying!! We have an Android version check just for this in JR. I’m surprised it didn’t catch this. Maybe we should use the same version in JR instead? |
I thought about this but to me my current solution is better. If javarosa can use the newest version I don't think we should downgrade it. |
|
I guess because JavaRosa doesn't make use of any part of the API that is out of bounds for Collect, we're ok for now. And if we do try to use an API we can't use in Collect, it's at that point that the JR Android check will catch it. Ok, works for me! |
lognaturel
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5178
The problem was that in Javarosa we merged getodk/javarosa#688 which added a new dependency
commons-io:commons-io:2.11.0. This dependency became automatically available in Collect and caused conflicts since the version we use is 2.5 and we can't use a newer one, see: #4158What has been done to verify that this works as intended?
I've verified that the crash does not occur anymore on Android 5.
Why is this the best possible solution? Were any other approaches considered?
I could also downgrade
commons-ioused in Javarosa to the version used in Collect and then maybe even remove it from Collect but I think those two project should have separate dependencies.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This should just fix the issue on Android 5 and have no side effects.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.