Skip to content
This repository has been archived by the owner on Apr 9, 2021. It is now read-only.

Adding back button in settings activity and confirmation dialog in main activity #373

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

htg2704
Copy link

@htg2704 htg2704 commented Mar 13, 2020

Closes #372
Closes #369

What has been done to verify that this works as intended?

Verified on a physical device.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Better user experience.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.

Copy link
Contributor

@huangyz0918 huangyz0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the CI conflicts and remove the unnecessary changes for the #372. Or you can open a new PR for #367 . But as for me, adding an exit button to settings activity is not a necessary change, but if you want, I'm ok.

build.gradle Outdated Show resolved Hide resolved
gradle/wrapper/gradle-wrapper.properties Outdated Show resolved Hide resolved
@ajay-prabhakar
Copy link
Contributor

@htg2704 are you still working on this?

@htg2704
Copy link
Author

htg2704 commented Apr 11, 2020

@Chromicle I made a commit 20 days back. I will see why it's not passing the test because according to me I made all necessary changes.

@ajay-prabhakar
Copy link
Contributor

yeah, but you build is failing due to pmd check, run ./gradlew checkcode locally you will get detailed information on how to solve that error
and please solve the conflicts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Add exit confirmation dialog
3 participants