Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omni for Emacs #12

Closed
4 tasks done
zoedsoupe opened this issue Feb 20, 2021 · 8 comments
Closed
4 tasks done

Omni for Emacs #12

zoedsoupe opened this issue Feb 20, 2021 · 8 comments

Comments

@zoedsoupe
Copy link
Member

zoedsoupe commented Feb 20, 2021

Add a new theme to the organization?

If you have already created a theme, make sure you check the following requirements:

  • The theme follows the template.
  • The theme follows the Omni Color Palette.
  • The branch name is main (we will keep this name pattern from now on)
  • The theme has instructions on how to install it.

Application: Emacs text editor
GitHub URL: https://github.com/Mdsp9070/emacs

So, this is my first attempt to port Omni theme to Emacs, it maybe have some minor improvents to do but the base is done.

I changed a bit the template to fit with Emacs unique configs and so on... Also, when this theme will have been accepted, I'll publish the package to MELPA repositories (https://github.com/melpa/melpa).

I tried to support all most used packages, but of course there are infinite other that would require some minor tweaks.

I'd like to ask you all if there are any suggestions to improve the Mode-line and the theme itself.

My toughts:

  1. Maybe the true colors variants are too lightened?
  2. Mode-line appears to be too much darkened?
  3. Fringe column and background are too different?
  4. I don't know why, but there is a light white bar that represents tabs void (but this occurs on all themes, on my emacs config)

Any suggestions or PR would be perfect!

Here's a quick screenshot with true colors support:
screenshot

@zoedsoupe
Copy link
Member Author

zoedsoupe commented Feb 23, 2021

UPDATE

I did some changes:

  • darkened a little true colors variants
  • added support for centaur tabs
  • corrected all font-locks colors
  • set line number column as same color of fringe and background
  • added pink and yellows color and yours lighter variants

This is the actual state:

screenshot

About those white bar of tabs voids: was a misconfig of my centaur tabs package!
I only needed to eval this functionn:

(centaur-tabs-headline-match)

What do you think?

@Javiercuba
Copy link

i liked it

@jpedroschmitz
Copy link
Member

It looks great to me @Mdsp9070!

I'll request a small minor change. Is it possible to add the Mode-line format section on the install file?
This file content will be listed on the website when we create it.

@zoedsoupe
Copy link
Member Author

Of course! Do tou think that the supported packages lists need to be on install file too?

@jpedroschmitz
Copy link
Member

I think we can keep it on the readme and maybe add a note on the install file linking to this section on the readme.

@zoedsoupe
Copy link
Member Author

Oh, great idea! I will add a note to link!

@zoedsoupe
Copy link
Member Author

Ok, I changed! I'll create the PR

@jpedroschmitz
Copy link
Member

Great job overall. The theme looks awesome. 💜

Don't forget to share it on social media, forums, and communities!

ps: Always wait for approval before transferring the repository to the org! I'll add the awaiting-transfer label when it's ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants