-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omni for Kitty #8
Comments
Hey @Mdsp9070, thanks for your contribution 💜 Taking a look at the theme, the theme colors file is missing. Also, this issue is a duplicate of #6. I think we can continue the conversation on the first issue and include you and @gabrielcaussi as contributors to the theme. What do you think? |
Indeed... I forgot to push the theme color file haha. I fixed it! Yes! I agree with you! Just want to notice that @gabrielcaussi 's theme don;t contemplate inactive tabs and so on! But this can be easy solved! |
Nice, I think you can open a PR on the @gabrielcaussi theme, improving it. Or you can wait till we merge the theme on the Omni org and then open a PR. After that, we can include you as a team member =D Thanks for your comprehension and help 💜 |
I'll open a PR on his repository! Thank you for the attencion! |
Hey @Mdsp9070, we have included the Kitty theme on the Omni org. If you'd like to open a PR, we will be glad to receive it =D I really appreciate any help you can provide. |
OK! I'll open the PR! Actually, I that am really glad to contribute (: |
@Mdsp9070, if you can change the screenshot when making the pull request. It got a bad quality because I use Window Manager and I had to take the printscreen off a virtual machine. Thanks! |
No problem! I'll use mine! |
Hey @gabrielcaussi I just openned the PR! |
Add a new theme to the organization?
If you have already created a theme, make sure you check the following requirements:
main
(we will keep this name pattern from now on)Application: Kitty terminal emulator
GitHub URL: https://github.com/Mdsp9070/kitty
Well, long time ago I created a standalone version for Kitty, here's the old repo URL: https://github.com/Mdsp9070/kitty-omni
I'm glad that you'd decided to receive officials contributions!
The text was updated successfully, but these errors were encountered: