Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Assets) SASS & SCSS compiling with media debug queries #440

Closed
Demonax opened this issue Mar 15, 2015 · 7 comments
Closed

(Assets) SASS & SCSS compiling with media debug queries #440

Demonax opened this issue Mar 15, 2015 · 7 comments

Comments

@Demonax
Copy link

Demonax commented Mar 15, 2015

I am stumped on this problem. Both SASS and SCSS are compiling, but I am getting a large number of media queries of this sort in my compiled CSS:

@media -sass-debug-info{filename{}line{font-family:\0000310}}

Not only that, but options passed to SASS_STYLE ('compact', 'compressed') do not seem to have any effect.

In pelicanconf.py I have set SASS_DEBUG_INFO = False, and took a shot at mucking around with ASSET_CONFIG:

ASSET_CONFIG = (( 'sass', 'debug_info = false' ),)

No luck yet. I am far from expert in any of these tools, so I'm out of ideas.

@avaris
Copy link
Member

avaris commented Apr 20, 2015

IIRC, any config to webassets components needs to be passed through ASSET_CONFIG. You defining SASS_STYLE or SASS_DEBUG_INFO in pelicanconf.py doesn't have any effect. ASSET_CONFIG format is ('config', 'value'), so you need to use:

ASSET_CONFIG = (
    ('sass_style', 'compact'),
    ('sass_debug_info', 'False') # I don't remember if it's case sensitive or not
) 

@atoohill
Copy link

Has anyone else seen this issue and found any solutions? I'm seeing the same items that Demonax sees.

@avaris
Copy link
Member

avaris commented Jun 30, 2015

@atoohill my suggestion isn't working?

@Demonax
Copy link
Author

Demonax commented Jul 1, 2015

I never could get it to work myself. I tried the suggestions for ASSET_CONFIG, and when those didn't work I tried default Sass options and a few other things, but the compiled CSS never reflected any changes I made.

@avaris
Copy link
Member

avaris commented Jul 2, 2015

@atoohill I just tested and ASSET_CONFIG is working fine for me. FWIW, boolean settings should be actual booleans:

ASSET_CONFIG = (
    ('sass_style', 'compact'),
    ('sass_debug_info', False),
) 

Can you show the settings you use and the relevant bits from the theme that uses assets?

Edit: Sort of wrong ping :). cc: @Demonax

@atoohill
Copy link

atoohill commented Jul 7, 2015

Thanks @avaris, your comment on booleans made the difference. Now we can do sass_styles of 'compact' and 'compressed' and it works great. Thanks!

@justinmayer
Copy link
Member

Seems like this has been sorted out, at least for @atoohill. Thanks, @avaris!

calfzhou pushed a commit to calfzhou/pelican-plugins that referenced this issue Sep 28, 2019
calfzhou pushed a commit to calfzhou/pelican-plugins that referenced this issue Sep 28, 2019
# [4.0.0](Pelican-Elegant/elegant@V3.2.0...V4.0.0) (2019-08-22)

### Bug Fixes

* **admonition:** an artifact in border behind the title ([88113c3](Pelican-Elegant/elegant@88113c3))
* **admonition:** reduce border radius to match radii of other components ([de08d20](Pelican-Elegant/elegant@de08d20)), closes [getpelican#490](Pelican-Elegant/elegant#490)
* **admonition:** remove box shadow ([d059db8](Pelican-Elegant/elegant@d059db8)), closes [getpelican#490](Pelican-Elegant/elegant#490)
* **admonition:** remove text-shadow from heading ([1c889da](Pelican-Elegant/elegant@1c889da)), closes [getpelican#490](Pelican-Elegant/elegant#490)
* **clean URL:** default URL of categories, tags and archives fails on some servers ([3c7df6a](Pelican-Elegant/elegant@3c7df6a)), closes [getpelican#280](Pelican-Elegant/elegant#280) [getpelican#276](Pelican-Elegant/elegant#276)
* **comments:** W3C validation errors ([76a1f26](Pelican-Elegant/elegant@76a1f26))
* **disqus:** remove SITEURL condition to show Disqus comments section ([753d5a5](Pelican-Elegant/elegant@753d5a5))
* **lang:** do not override default value of DEFAULT_LANG set by Pelican ([d6c60c2](Pelican-Elegant/elegant@d6c60c2))
* **social:** reduce icon sizes in the sidebar ([c769ba3](Pelican-Elegant/elegant@c769ba3))
* **social:** use nofollow for social links in the sidebar ([50cff87](Pelican-Elegant/elegant@50cff87))
* **social:** W3C validation error ([ec4521e](Pelican-Elegant/elegant@ec4521e))
* **table:** reduce border radius to match radii of other components ([7eaaa96](Pelican-Elegant/elegant@7eaaa96))
* **w3c validation:** remove incorrect usage of article tag ([e8231e0](Pelican-Elegant/elegant@e8231e0)), closes [getpelican#251](Pelican-Elegant/elegant#251)
* **w3c validation:** remove obsolete charset attribute ([8deb285](Pelican-Elegant/elegant@8deb285)), closes [getpelican#251](Pelican-Elegant/elegant#251)
* **w3c validation:** remove redundant article tag ([d07c27e](Pelican-Elegant/elegant@d07c27e)), closes [getpelican#251](Pelican-Elegant/elegant#251)
* **w3c validation:** remove redundant sections without heading ([df9221f](Pelican-Elegant/elegant@df9221f)), closes [getpelican#251](Pelican-Elegant/elegant#251)
* **w3c validation:** remove type and language attributes ([b700224](Pelican-Elegant/elegant@b700224)), closes [getpelican#251](Pelican-Elegant/elegant#251)
* **w3c validation:** update CSS rules ([0b78d46](Pelican-Elegant/elegant@0b78d46)), closes [getpelican#251](Pelican-Elegant/elegant#251)

### Features

* **404:** auto fill search box with URL fragment that was not found ([c0a7f47](Pelican-Elegant/elegant@c0a7f47))
* **admonition:** add box shadow ([246f826](Pelican-Elegant/elegant@246f826))
* **admonition:** border color should match the title color ([1adadbe](Pelican-Elegant/elegant@1adadbe))
* **admonition:** increase contrast of title ([7fb82cc](Pelican-Elegant/elegant@7fb82cc))
* **admonition:** use svg image instead of font-awesome icon ([e7c4029](Pelican-Elegant/elegant@e7c4029)), closes [getpelican#487](Pelican-Elegant/elegant#487)
* **clean url:** support clean URL for search page ([088791e](Pelican-Elegant/elegant@088791e))
* **comments:** add support for utterances comment system ([a2151cc](Pelican-Elegant/elegant@a2151cc)), closes [getpelican#288](Pelican-Elegant/elegant#288)
* **quotes:** improve style and remove font-awesome for quote icon ([9ef3ac8](Pelican-Elegant/elegant@9ef3ac8)), closes [getpelican#487](Pelican-Elegant/elegant#487)
* **social:** add icons for 7 more websites ([8dcf8fa](Pelican-Elegant/elegant@8dcf8fa)), closes [getpelican#494](Pelican-Elegant/elegant#494)
* **social:** use svg icons instead of font-awesome ([19f458b](Pelican-Elegant/elegant@19f458b))
* **table:** add style rule to make tables pop out ([6a8500b](Pelican-Elegant/elegant@6a8500b)), closes [getpelican#440](Pelican-Elegant/elegant#440)

### Performance Improvements

* **admonition:** add attributes to svg iamges ([a740a60](Pelican-Elegant/elegant@a740a60))
* **requests:** remove font awesome ([7c20145](Pelican-Elegant/elegant@7c20145)), closes [getpelican#487](Pelican-Elegant/elegant#487)

### BREAKING CHANGES

* **requests:** We have removed font awesome. Now we use svg images for all icons. This will result
in one less web request, which in turn will improve your websites performance.
* **social:** Style customization and configuration of social icons
in the sidebar has changed.

New icons have better colors and bigger sizes.
* **clean URL:** To enable clean URLs for tags, categories and archives,
first configure your server to support clean URLs. Then set `TAGS_URL`,
`CATEGORIES_URL` and `ARCHIVES_URL` to `"tags"`, `"categories"` and
`"archives"` respectively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants