-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store sensitive data in a secret store, not Porter's database #1027
Comments
The current plan is to allow users to specify a destination for porter output through the same secrete plugin they use for resolving secrete values that needed to run bundle. [[secrets]] [secrets.config] After checking the limitations on Azure key vault and Hashicorp vault, it looks like the upper limit for number of keys stored in a vault is only affected by the underlying storage space. However, Hashicorp does have a per object size limit. Therefore, I plan to store each installation output separately using installation id or run id. |
This sounds like a good plan, looking forward to your PR! 🚀 |
Here's a list of additional content we need to properly document this feature (and yeah it's backfilling missing content we have always been missing!) It doesn't have to all be done in a single PR and we can work on some of this together.
|
I will start work on the Quickstart document |
Started on the Task document |
After looking at the example output from azure keyvault, we probably should add an dash in the secret key to make it more friendly to users to see |
Is this okay to close? |
Claims store sensitive data (parameters) and should not be stored in the database. We should come up with a way to store sensitive data from claims and other tables in the user's secret store, then when we retrieve the data, look up the sensitive values if needed to get a full document.
For some calls, maybe we don't need the data, we are just listing claims, but others like retrieving outputs and showing the values, will need to get the real values from the secret store.
The text was updated successfully, but these errors were encountered: