Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build arm64 images #2870

Open
ludfjig opened this issue Aug 14, 2023 · 3 comments
Open

build arm64 images #2870

ludfjig opened this issue Aug 14, 2023 · 3 comments
Labels
1 - 🍫 Eat chocolate _after_ emergency donuts bug Oops, sorry! gap We missed a spot hacktoberfest Issues chosen for Hacktoberfest 2023 hmm 🛑🤔 Needs more thinking time. Don't start on it yet, please. self care 💅 Little things that help the project and our community #self-care-friday suggestion Idea for maintainers to consider. Do not take this issue until triaged. user experience 🌈💖 Make it easier for everyone to use Porter

Comments

@ludfjig
Copy link
Contributor

ludfjig commented Aug 14, 2023

We should be building arm64 images, not only amd64. It is also requested by mcr

@ludfjig ludfjig added the suggestion Idea for maintainers to consider. Do not take this issue until triaged. label Aug 14, 2023
@troy0820 troy0820 added bug Oops, sorry! user experience 🌈💖 Make it easier for everyone to use Porter gap We missed a spot hmm 🛑🤔 Needs more thinking time. Don't start on it yet, please. 1 - 🍫 Eat chocolate _after_ emergency donuts self care 💅 Little things that help the project and our community #self-care-friday labels Aug 15, 2023
@troy0820
Copy link
Member

Couple of other issues are linked to this one sort of.

#2397
#1497
#1856

I think the problem is related to some of these with the bugs that were reported. However, these issues are old and we may not face the same problems. Worth investigating.

@schristoff schristoff added the hacktoberfest Issues chosen for Hacktoberfest 2023 label Sep 22, 2023
@sbshah97
Copy link
Contributor

sbshah97 commented Jan 5, 2024

Hi can someone help on how to approach this and go about this? I am a new contributor here

@robinbraemer
Copy link
Contributor

robinbraemer commented Jun 7, 2024

Porter's mission is to be a widely accessible cloud-native apps CLI, yet it doesn't support arm, that is widely used nowadays server- and clientside. This issue deserves more attention from core maintainers as it is directly correlated to the success of adopting Porter and CNAB.

From what I see, to make progress would be to add arm to these locations(?):

Go builds should use as already defaulted as ARGS by Docker BuildKit:

GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} go build

Docker builds should add a platforms flag:

docker build --platform linux/amd64,linux/arm64 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🍫 Eat chocolate _after_ emergency donuts bug Oops, sorry! gap We missed a spot hacktoberfest Issues chosen for Hacktoberfest 2023 hmm 🛑🤔 Needs more thinking time. Don't start on it yet, please. self care 💅 Little things that help the project and our community #self-care-friday suggestion Idea for maintainers to consider. Do not take this issue until triaged. user experience 🌈💖 Make it easier for everyone to use Porter
Projects
None yet
Development

No branches or pull requests

5 participants