Migrate visualizations registry/renderer/editor to React #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
arikfr
reviewed
Feb 27, 2019
…llowing visualizations migration)
kravets-levko
changed the title
ranbena
reviewed
Mar 5, 2019
ranbena
reviewed
Mar 5, 2019
|
I've noticed we show the Widget title differently now: we only show visualization name without the query name.
|
arikfr
reviewed
Apr 14, 2019
There was a problem hiding this comment.
Issues I noticed with filters:
- Previously you could narrow down filter options by typing -- this is no longer possible. I guess it's a simple toggle on the Ant component?
- We used to show the visualization preview in the editor along with filters -- this is no longer the case.
- When switching visualizations it resets the filter.
|
One more issue with filters:
|
|
@arikfr Fixed all notices, can you check it once more please? |
arikfr
approved these changes
Apr 29, 2019
arikfr
approved these changes
Apr 29, 2019
|
@kravets-levko i didn't yet get another chance to look at the newer code but i support merging it anyway. Let's get it out of your way 👍🏻 |
|
🚀 |
9 tasks
24 tasks
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Prepare base for upcoming visualizations migration (one by one).
<svg>tags on page 🤦♂️)Migrated some simplest editors to React (as an example for future refactoring).
Also, this PR required migrating filters to React as well.
Related Tickets & Documents
Replaces #2988
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Visualizations itself didn't change - they're still rendered by the same AngularJS components. Visualization Editor dialog and Filters are now 100% React/AntD and therefore looks a bit differently.