(WIP) feat: Added Australia to Choropleth visualisation #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arihantsurana
changed the title
arihantsurana
force-pushed
the
add-australia-choropleth
branch
from
5d72024
to
9323cba
Compare
arikfr
reviewed
Dec 5, 2019
| @@ -0,0 +1 @@ | |||
| ./client/app/visualizations/choropleth/maps/australia.postcodes.geo.json filter=lfs diff=lfs merge=lfs -text | |||
There was a problem hiding this comment.
What's this about?
Not sure if related, but this PR is missing the actual map JSON files.
There was a problem hiding this comment.
yeah I tried to upload it, but its hitting the limits of github file sizes.
I will down-sample the map and create another PR for this.
There was a problem hiding this comment.
@kravets-levko is working on a way to load custom maps without adding them to the repo (#4599), so maybe just wait for it and load the map from an external source?
|
Looks like the PR is abandoned. I'm closing it, but if you would like to continue working on it and address the comments -- let me know and will reopen. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adding the Australian postcode map for Choropleth visualisation options
Related Tickets & Documents
related issue, discusses the need for making Choropleth more customisable: #2317
and this discussion talks about the same: https://discuss.redash.io/t/choropleth-map-per-regions/4437/3
While this is a good feature for future releases, I wanted to add Australian map, just so we can use this in our redash instance till the feature for custom GeoJson is available.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
WIP