Table visualization with column named "children" renders +/- buttons #4394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, it is supposed to be a very simple fix, I missed the part of the docs that mentioned
In the docs it seem that prop is an string array, so perhaps |
| @@ -65,6 +65,7 @@ export default function Renderer({ options, data, context }) { | |||
| data-test="TableVisualization" | |||
| columns={tableColumns} | |||
| dataSource={preparedRows} | |||
| childrenColumnName={null} | |||
There was a problem hiding this comment.
Suggested change
| childrenColumnName={null} | |
| childrenColumnName={[]} |
There was a problem hiding this comment.
There was a problem hiding this comment.
That worked after I update Antd, maybe they changed it to allow array recently?
There was a problem hiding this comment.
childrenName prop is declared as optional/nullable, but later there are no any conditions - it's just used as is - e.g. item[this.props.childrenName] - implicit cast to string. I'll try to find another solution.
kravets-levko
changed the title
kravets-levko
changed the title
gabrieldutra
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Fixes #4393
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Before:
After:
