Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Query Runner: Apache Pinot #5446

Closed
wants to merge 1 commit into from

Conversation

justrp
Copy link

@justrp justrp commented Mar 28, 2021

What type of PR is this? (check all applicable)

  • New Query Runner (Data Source)

Description

Query runner for http://pinot.apache.org/

Related Tickets & Documents

apache/pinot#6297

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@etadelta222
Copy link

Hi @kravets-levko , has this been abandoned?

@justrp
Copy link
Author

justrp commented Feb 5, 2022

oh, wow, I almost forgot about this one: it's been almost a year)
rebased from current master branch

@etadelta222
Copy link

Hi @arikfr , @rauchy , can someone help with this?

@susodapop
Copy link
Contributor

susodapop commented Mar 17, 2022

Hey @justrp and @etadelta222 thanks so much for the ping. We just introduced our new process for reviews which includes a new PR template you can see here. Would you mind updating the PR description? Really all we need to see is the applicable versions of pinot for which this query runner will work.

I'm looking forward to getting this reviewed and merged ASAP!

@susodapop susodapop added Needs More Information Seen by a team member, not ready for a full review and removed Backend labels Mar 17, 2022
@susodapop susodapop changed the title pinot runner New Query Runner: Apache Pinot Mar 17, 2022
@susodapop susodapop requested review from susodapop and removed request for arikfr and rauchy March 17, 2022 17:53
@susodapop susodapop assigned susodapop and unassigned kravets-levko Mar 17, 2022
"FLOAT": TYPE_FLOAT,
"DOUBLE": TYPE_FLOAT,
"STRING": TYPE_STRING,
"BYTES": TYPE_STRING,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more types here, especially the TIMESTAMP

@@ -42,3 +42,4 @@ xlrd==2.0.1
openpyxl==3.0.7
firebolt-sdk
pandas==1.3.4
pinotdb==0.3.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.3.11 is the latest version :p

@etadelta222
Copy link

Hi @susodapop , is the information provided by Xiangfu sufficient?

@justrp
Copy link
Author

justrp commented Mar 24, 2022

in case if you wait for me to address these changes - unfortunately, can't provide clear ETA - got a very busy time now :(
hopefully, will have some time at week after the next one - but can't predict for sure

@susodapop
Copy link
Contributor

Another contributor has opened #5724 which duplicates this PR. Since @justrp is currently busy, I'm closing this one for now but have asked the author of 5724 to incorporate @xiangfu0's feedback into their effort.

@susodapop susodapop closed this Apr 4, 2022
@xiangfu0 xiangfu0 mentioned this pull request Jul 19, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs More Information Seen by a team member, not ready for a full review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants