Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Firebolt data source #5606

Merged
merged 11 commits into from
Oct 14, 2021

Conversation

rajeshmauryasde
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Adding a query runner for firebolt

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Screenshot 2021-09-30 at 6 30 53 PM

Screenshot 2021-09-30 at 6 37 48 PM

@rajeshmauryasde
Copy link
Contributor Author

rajeshmauryasde commented Oct 1, 2021

Hi,
I compared the files produced by percy/redash for getredash:master and rajeshSigmoid:firebolt-integration. Didn't find any visual change. Please review it.

@kevinmarr
Copy link

Hi Redash team! I'm leading Firebolt's integrations team and Rajesh has been working with me to add this connector. Would super appreciate if someone could take a look at this PR and merge it if all looks good. @arikfr @kravets-levko @susodapop

Copy link
Contributor

@susodapop susodapop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

@susodapop susodapop merged commit 143d22d into getredash:master Oct 14, 2021
@susodapop
Copy link
Contributor

Thanks for pinging us @rajeshSigmoid and @kevinmarr . Busy days with the V10 release and redash-migrate. It's good to get a reminder 😃

@kevinmarr
Copy link

kevinmarr commented Oct 19, 2021 via email

@kevinmarr
Copy link

@susodapop When will the next release happen that includes this PR? Should we be telling our customers to build directly from source code while we wait for the next release?

@susodapop
Copy link
Contributor

Will aim to include this in the V10.1 release shortly.

@kevinmarr
Copy link

Great, thank you! Now, for the annoying follow-up question: when will the V10.1 release go out?

@susodapop
Copy link
Contributor

shortly

@kevinmarr
Copy link

😂

arikfr pushed a commit that referenced this pull request Nov 23, 2021
* Update changelog to incorporate security fixes and #5632 & #5606

* Added reference to sqlite fix
susodapop pushed a commit that referenced this pull request Nov 23, 2021
susodapop added a commit that referenced this pull request Nov 23, 2021
* Update changelog to incorporate security fixes and #5632 & #5606

* Added reference to sqlite fix
arikfr pushed a commit that referenced this pull request Nov 24, 2021
* Add support for Firebolt Database (#5606)

* Fixes issue #5622 (#5623)

* Update Readme to reflect Firebolt data source (#5649)

* Speed up BigQuery schema fetching (#5632)

New method improves schema fetching by as much as 98% on larger schemas

* Merge pull request from GHSA-vhc7-w7r8-8m34

* WIP: break the flask_oauthlib behavior

* Refactor google-oauth to use cryptographic state.

* Clean up comments

* Fix: tests didn't pass because of the scope issues.

Moved outside the create_blueprint method because this does not depend
on the Authlib object.

* Apply Arik's fixes. Tests pass.

* Merge pull request from GHSA-g8xr-f424-h2rv

* Merge pull request from GHSA-fcpv-hgq6-87h7

* Update changelog to incorporate security fixes and #5632 & #5606 (#5654)

* Update changelog to incorporate security fixes and #5632 & #5606

* Added reference to sqlite fix

* Bump to V10.1

* Missed package-lock.json on the first pass

* Add a REDASH_COOKIE_SECRET for circleci

* Revert "Add a REDASH_COOKIE_SECRET for circleci"

This reverts commit 4576636.

Moves config to the correct compose files

* Move advocate to core requirements.txt file

[debugging circleci failures]

Co-authored-by: rajeshSigmoid <89909168+rajeshSigmoid@users.noreply.github.com>
Co-authored-by: Aratrik Pal <44343120+AP2008@users.noreply.github.com>
Co-authored-by: rajeshmauryasde <rajeshk@sigmoidanalytics.com>
Co-authored-by: Katsuya Shimabukuro <katsu.generation.888@gmail.com>
@susodapop
Copy link
Contributor

😂

The latest release (10.1) includes the Firebolt data source. Once you upgrade to 10.1 Firebolt becomes an option 👍

@kevinmarr
Copy link

Wooo! Thanks @susodapop !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants