-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert build (2 of 2) #6967
Revert build (2 of 2) #6967
Conversation
This change should be rebased once #6965 is merged |
#!/bin/bash | ||
NAME=redash | ||
VERSION=$(jq -r .version package.json) | ||
FULL_VERSION=$VERSION+b$CIRCLE_BUILD_NUM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably look into that $CIRCLE_BUILD_NUM
variable at some future point, since we're not using CircleCI any more.
Not super relevant for this PR though. 😉
curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor -o /usr/share/keyrings/microsoft-prod.gpg \ | ||
&& curl https://packages.microsoft.com/config/debian/12/prod.list > /etc/apt/sources.list.d/mssql-release.list \ | ||
&& apt-get update \ | ||
&& ACCEPT_EULA=Y apt-get install -y --no-install-recommends msodbcsql17 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After we apply this PR, we'll probably want to re-apply the patch which updates to v18 of MS ODBC SQL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely
@eradman Just tried updating this after merging the first patch, and its now failing the lint checks (and possibly other stuff too). You ok to look into it? 😄 |
I actually put the |
getredash#6964 Commands used cp -r ../redash-alt/.ci . cp -r ../redash-alt/client/cypress client/ cp ../redash-alt/Dockerfile . cp ../redash-alt/Makefile . cp ../redash-alt/bin/docker-entrypoint bin/ cp ../redash-alt/compose.yaml . cp ../redash-alt/package.json . git rm Dockerfile.cypress git add .ci/* git add client/cypress/cypress.js client/cypress/integration/dashboard/*.js git add Dockerfile Makefile bin/docker-entrypoint compose.yaml package.json black tests/handlers/test_query_results.py git add tests/handlers/test_query_results.py git commit -m 'Revert build (2 of 2)'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 😄
What type of PR is this?
Description
Commands used
How is this tested?
Related Tickets & Documents
#6964