Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert CI workflow (1 of 2) #6965

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

eradman
Copy link
Collaborator

@eradman eradman commented May 13, 2024

What type of PR is this?

  • Revert

Description

Commands used

rm -rf .github/
cp -r ../redash-alt/.github .

git add .github/workflows/ci.yml .github/workflows/preview-image.yml

git commit -m 'Revert CI workflow'

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually

Related Tickets & Documents

#6964

@eradman eradman requested a review from justinclift May 13, 2024 14:47
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.83%. Comparing base (1b946b5) to head (597aae9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6965   +/-   ##
=======================================
  Coverage   63.83%   63.83%           
=======================================
  Files         161      161           
  Lines       13094    13094           
  Branches     1814     1814           
=======================================
  Hits         8359     8359           
  Misses       4432     4432           
  Partials      303      303           

- run: ruff check .
- run: black --check .

backend-unit-tests:
runs-on: ubuntu-22.04
needs: backend-lint
env:
FRONTEND_BUILD_MODE: 0
COMPOSE_FILE: .ci/compose.ci.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a sub-directory? 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no. I am staging this as two separate commits. I'll post the second so you can see what I'm trying to do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. 😄

- run: yarn lint

frontend-e2e-tests:
runs-on: ubuntu-22.04
needs: frontend-lint
env:
COMPOSE_FILE: .ci/compose.cypress.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

@justinclift
Copy link
Member

Aside from the .ci subdirectory query, the rest looks workable. 😄

getredash#6964

Commands

rm -rf .github/
cp -r ../redash-alt/.github .

git add .github/workflows/ci.yml .github/workflows/preview-image.yml

git commit -m 'Revert CI workflow (1 of 2)'
@eradman eradman changed the title Revert CI workflow Revert CI workflow (1 of 2) May 14, 2024
@eradman eradman mentioned this pull request May 14, 2024
4 tasks
Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good to me.

Thanks @eradman. 😄

@justinclift justinclift merged commit 753ea84 into getredash:master May 14, 2024
13 checks passed
@eradman eradman deleted the revert-ci-workflow branch May 14, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants