Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When will stable CHANNEL be updated? #53

Closed
snickerjp opened this issue Feb 6, 2024 · 7 comments
Closed

When will stable CHANNEL be updated? #53

snickerjp opened this issue Feb 6, 2024 · 7 comments

Comments

@snickerjp
Copy link
Member

When will stable CHANNEL be updated?

in setup.sh

setup/setup.sh

Lines 63 to 64 in e611a6a

REQUESTED_CHANNEL=stable
LATEST_VERSION=$(curl -s "https://version.redash.io/api/releases?channel=$REQUESTED_CHANNEL" | json_pp | grep "docker_image" | head -n 1 | awk 'BEGIN{FS=":"}{print $3}' | awk 'BEGIN{FS="\""}{print $1}')

return 8.0.0.b32245

$ curl -s "https://version.redash.io/api/releases?channel=stable" | json_pp | grep "docker_image" | head -n 1 | awk 'BEGIN{FS=":"}{print $3}' | awk 'BEGIN{FS="\""}{print $1}'
8.0.0.b32245

Is #11 relevant?

Reason.

Because I would like to update my version of Redash.

However, if I go to setup.sh and get the version
replacement, so I cannot update it without modifying setup.sh.

setup/setup.sh

Line 69 in e611a6a

sed -ri "s/image: redash\/redash:([A-Za-z0-9.-]*)/image: redash\/redash:$LATEST_VERSION/" docker-compose.yml

I would like to improve this situation.

@justinclift
Copy link
Member

The setup script has been updated to just embed the desired version directly, rather than make any external calls.

We still need to create a new stable Redash release however, and/or update the setup script to work ok with the preview release until that's ready.

Thinking about it more, getting the preview image to work with the setup script is probably more urgent than the other stuff I was planning on doing next. So, I'll look at it later on today. 😄

@justinclift
Copy link
Member

@snickerjp Would you be ok to try the setup.sh that's in this PR?

Direct download link: https://github.com/getredash/setup/raw/preview_v1/setup.sh

That setup.sh has a new --preview option makes it use the latest preview image from Docker Hub rather than the old official release.

In my initial testing so far, it's working ok. 😄

@snickerjp
Copy link
Member Author

Understood. I will give it a try!

@snickerjp
Copy link
Member Author

snickerjp commented Apr 3, 2024

@justinclift

Result was OK.
I tried it in two environments.

  • OS

    • Ubuntu 18.04
    • Ubuntu 22.04
  • sudo bash setup.sh --preview
    image
    image

  • sudo bash setup.sh
    image

@justinclift
Copy link
Member

Thanks, it looks like that PR is going in the right direction. 😄

I still need to make some further improvements to it (and test it more too) before it's ready for merging though.

@justinclift
Copy link
Member

@snickerjp That PR has been merged, as the preview release seems ok for people to use.

It hasn't had wide enough testing for it to be a new "STABLE" release though. And we'd better make sure the upgrading process always works before we do that. 😬

@snickerjp
Copy link
Member Author

Thanks for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants