Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Failure notification is sent before "started" one when task fails early #37

Closed
rshk opened this issue Aug 12, 2015 · 1 comment
Closed

Comments

@rshk
Copy link
Contributor

rshk commented Aug 12, 2015

Not a huge issue, but it might get confusing:

2015-08-12_103828

I guess it's caused by https://github.com/getsentry/freight/blob/master/freight/notifiers/utils.py#L55-L62 (why not something like: add to queue anyways -> if event == FINISHED then send all from queue, btw?)

@dcramer
Copy link
Member

dcramer commented Aug 12, 2015

Dupe of #33

We could do the queue thing, but I'd prefer if we just have a way to revoke the pending notification (theres other situations we sort of need to as well, where the queue takes a minute and then it ends up sending all of them)

@dcramer dcramer closed this as completed Aug 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants