-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_auto_calculate_content_length_doesnt_override_existing_value fails #635
Comments
this is caused by the new version of urllib. I will see what we can do to fix it ASAP |
@markstory Rationale you can find here: urllib3/urllib3#2514 I propose to bump urllib dependency and on the side of what do you think? |
I admit Which is to say: thank you, this is probably the best we can do. |
Avoid installing urllib3>=2 for CI runs as the responses module is not compatible with that version yet (leading to failing tests because mocking HTTP responses in not working correctly). Supposedly getsentry/responses#635 is the relevant upstream issue.
Avoid installing urllib3>=2 for CI runs as the responses module is not compatible with that version yet (leading to failing tests because mocking HTTP responses in not working correctly). Supposedly getsentry/responses#635 is the relevant upstream issue.
Describe the bug
When running test suite of 0.23.1 while packaging this on openSUSE/Tumbleweed (with urllib3 2.0.1, and requests 2.30.0) the test case test_auto_calculate_content_length_doesnt_override_existing_value fails:
Additional context
Complete build log with all details about packages used and steps taken to reproduce.
Version of
responses
0.23.1
Steps to Reproduce
Run the test suite
Expected Result
Test passes
Actual Result
It doesn’t (see above).
Actually, I was trying to make responses work with the new urllib3, so I have added these two patches:
and
a bit larger one (I assumed, that it is better to deal with the upgraded urllib3 head on instead of pretending to use the bundled one):
However, even the second one didn’t prevent this failed test from happening.
Any ideas, what’s wrong?
The text was updated successfully, but these errors were encountered: