Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snapshot): Handle removed attributes #65

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 27, 2023

@mydea
Copy link
Member

mydea commented Feb 27, 2023

Let's merge this: #66 into this branch, then merge this and cut a release 🚀

This adds on top of #65 and adds
a test for this, as well as streamlining this check in the
`transformAttribute` method.
@mydea
Copy link
Member

mydea commented Feb 27, 2023

Let's maybe update the PR title to something like:

fix(snapshot): Handle removed attributes ? As that is actually what we're fixing here 😅

@Lms24 Lms24 changed the title fix(snapshot): Handle undefined in defaultMaskFn fix(snapshot): Handle removed attributes Feb 27, 2023
@mydea
Copy link
Member

mydea commented Feb 27, 2023

Opened an upstream PR for this as well: rrweb-io#1157

@Lms24 Lms24 merged commit c6c922b into sentry-v1 Feb 27, 2023
@Lms24 Lms24 deleted the lms/fix-undefined-in-defaultMaskFn branch February 27, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Uncaught TypeError: Cannot read properties of null (reading 'replace')" from replay mutation observer
2 participants