PR fix: Add test for null attribute #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Feb 27, 2023
| @@ -242,32 +242,35 @@ export function transformAttribute( | |||
| maskAllText: boolean, | |||
| maskTextFn: MaskTextFn | undefined, | |||
| ): string { | |||
| if (!value) { | |||
There was a problem hiding this comment.
l: should we change value's type to string | undefined | null in the function signature to reflect that it apparently can be undefined/null?
There was a problem hiding this comment.
hmm, it seems there is actually a longer tail to this (as a lot of types seem to depend on the return value of this being string.)
So IMHO it's correct, but let's look at this separately maybe then!
EDIT: nevermind, I ended up fixing the type!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds on top of #65 and adds a test for this, as well as streamlining this check in the
transformAttributemethod.