feat: Ensure password inputs are always masked #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
approved these changes
Mar 7, 2023
| // Change type to text (simulate "show password") | ||
| await page.click('#show-password'); | ||
| await page.type('#password', 'XY'); | ||
| await page.click('#show-password'); |
There was a problem hiding this comment.
This toggles it back to type: password? It might be better to test leaving it as text
There was a problem hiding this comment.
We test before this line (on 512) that it works while being a text field, so I think this should be OK?
Lms24
approved these changes
Mar 8, 2023
Yeah, I think the type change stuff makes sense to upstream. Not sure if they would like to have the "do not allow to opt-out of password" stuff upstream, but I guess I can also just ask! |
|
Added upstream PR: rrweb-io#1170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
type="password"inputstype=passwordand have this type changed (so e.g. through a "show password" toggle) always keep the password masked, even afterwards.We should never record passwords, and e.g.
toggle passwordtype buttons are quite common and would easily leak the password into the replay as of now.We do this by adding a
rr_is_passwordattribute to the HTML input when the type is changed frompasswordto something else. This is IMHO the easiest solution for this, and since we only add this when the type is really changed (so not eagerly for all inputs) IMHO it's an acceptable tradeoff to have this in the DOM.Closes #34