Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

sentry-java v-next #495

Merged
merged 40 commits into from
Sep 10, 2020
Merged

sentry-java v-next #495

merged 40 commits into from
Sep 10, 2020

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Jul 27, 2020

base PR when bulding sentry-java based on this repository.

If the PR isn't adding a breaking change or won't negativily affect the Android SDK it case it can target master instead

@lgtm-com
Copy link

lgtm-com bot commented Aug 27, 2020

This pull request introduces 1 alert when merging 68c7ceb into 42d74d9 - view on LGTM.com

new alerts:

  • 1 for Disabled Spring CSRF protection

@bruno-garcia
Copy link
Member Author

This pull request introduces 1 alert when merging 68c7ceb into 42d74d9 - view on LGTM.com

new alerts:

* 1 for Disabled Spring CSRF protection

@maciejwalkowiak LGTM check failed on the last PR, so we misse this ^

@lgtm-com
Copy link

lgtm-com bot commented Aug 29, 2020

This pull request introduces 1 alert when merging 2d6e215 into 42d74d9 - view on LGTM.com

new alerts:

  • 1 for Disabled Spring CSRF protection

* Add `sendDefaultPii` flag to `SentryOptions`.

Filters out user information and sensitive request headers in Spring Boot integration if this flag is set to false.

* Polish.
@lgtm-com
Copy link

lgtm-com bot commented Aug 30, 2020

This pull request introduces 1 alert when merging 0a8bde6 into 42d74d9 - view on LGTM.com

new alerts:

  • 1 for Disabled Spring CSRF protection

@lgtm-com
Copy link

lgtm-com bot commented Sep 1, 2020

This pull request introduces 1 alert when merging 82e4efe into 42d74d9 - view on LGTM.com

new alerts:

  • 1 for Disabled Spring CSRF protection

@maciejwalkowiak
Copy link
Contributor

Looks like adding @SuppressWarnings("lgtm[java/spring-disabled-csrf-protection]") helps with hiding error at lgtm.com but not from getting an alert :/

@bruno-garcia
Copy link
Member Author

Let's ignore it for now. We might have to open an ticket with them later

@lgtm-com
Copy link

lgtm-com bot commented Sep 2, 2020

This pull request introduces 1 alert when merging 35750dd into 282d224 - view on LGTM.com

new alerts:

  • 1 for Disabled Spring CSRF protection

@lgtm-com
Copy link

lgtm-com bot commented Sep 3, 2020

This pull request introduces 1 alert when merging cd6f526 into 282d224 - view on LGTM.com

new alerts:

  • 1 for Disabled Spring CSRF protection

@lgtm-com
Copy link

lgtm-com bot commented Sep 4, 2020

This pull request introduces 1 alert when merging 60af521 into 2d48d1a - view on LGTM.com

new alerts:

  • 1 for Disabled Spring CSRF protection

@bruno-garcia
Copy link
Member Author

I wish @lgtm-com would respect the suppression and stop reposing this every time.
It's a bloddy sample LGTM, go home.

@bruno-garcia bruno-garcia marked this pull request as ready for review September 8, 2020 18:49
@lgtm-com
Copy link

lgtm-com bot commented Sep 8, 2020

This pull request introduces 2 alerts when merging 923f9fc into 2d48d1a - view on LGTM.com

new alerts:

  • 2 for Disabled Spring CSRF protection

@bruno-garcia bruno-garcia changed the base branch from master to 3.0.0 September 9, 2020 15:45
@bruno-garcia
Copy link
Member Author

CI is unhappy

w: Runtime JAR files in the classpath should have the same version. These files were found in the classpath:
    /Users/runner/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-jdk8/1.4.0/e3765b66f0610afc92053ff1a93a87a544fca2b/kotlin-stdlib-jdk8-1.4.0.jar (version 1.4)
    /Users/runner/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-jdk7/1.3.72/3adfc2f4ea4243e01204be8081fe63bde6b12815/kotlin-stdlib-jdk7-1.3.72.jar (version 1.3)
    /Users/runner/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/1.3.72/8032138f12c0180bc4e51fe139d4c52b46db6109/kotlin-stdlib-1.3.72.jar (version 1.3)
    /Users/runner/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-common/1.3.72/6ca8bee3d88957eaaaef077c41c908c9940492d8/kotlin-stdlib-common-1.3.72.jar (version 1.3)

@bruno-garcia bruno-garcia changed the base branch from 3.0.0 to master September 9, 2020 16:12
@bruno-garcia
Copy link
Member Author

I've pulled 3.0.0 into it, which pulled master earlier today.
Changing base to master again.

Once CI is green we can merge this.

@bruno-garcia bruno-garcia merged commit 4b6f0a0 into master Sep 10, 2020
@bruno-garcia bruno-garcia deleted the feat/sentry-java branch September 10, 2020 22:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants