fix(bug): Using annotated tags now returns the correct commit SHA #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iProgramStuff
requested review from
mitsuhiko,
markstory,
dashed and
bruno-garcia
bruno-garcia
requested changes
Sep 18, 2019
bruno-garcia
approved these changes
Sep 18, 2019
dashed
approved these changes
Sep 18, 2019
jan-auer
requested changes
Sep 20, 2019
jan-auer
approved these changes
Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer was experiencing an issue when trying to specify commits using an annotated tag. The
find_matching_revfunction was returning the SHA of the tag instead of getting the SHA of it's associated commit.This PR fixes that, and adds two tests (one against a lightweight tag, and one against an annotated tag) to ensure it's correctness and keep it correct.