Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(discover): Add a device.language field #29879

Closed
wants to merge 3 commits into from

Conversation

wmak
Copy link
Member

@wmak wmak commented Nov 9, 2021

  • This is a new field for mobile devices that reports the language of
    the device for additional context

- This is a new field for mobile devices that reports the language of
  the device for additional context
@wmak wmak requested a review from a team as a code owner November 9, 2021 16:21
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021

size-limit report

Path Base Size (76ce62f) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.82 KB 52.82 KB -0.01% 🔽
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@philipphofmann
Copy link
Member

We shouldn't go forward with this PR as device.language is deprecated we should use culture_context instead, see #30525.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2021
@mgaeta mgaeta deleted the wmak/feat/device-language branch March 18, 2022 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants