Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sanitize span data #1963

Merged
merged 6 commits into from
Jul 13, 2022
Merged

fix: sanitize span data #1963

merged 6 commits into from
Jul 13, 2022

Conversation

kevinrenskers
Copy link
Contributor

@kevinrenskers kevinrenskers commented Jul 12, 2022 •
edited

馃摐 Description

Sanitize span data when serializing.

馃挕 Motivation and Context

Closes #1307

馃挌 How did you test it?

Unit tests

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

馃敭 Next steps

@kevinrenskers kevinrenskers marked this pull request as ready for review July 12, 2022 13:47
philipphofmann
philipphofmann approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the sanitation for the tags. Then LGTM 馃殌 and we can merge.

CHANGELOG.md Outdated Show resolved Hide resolved
Sources/Sentry/SentrySpan.m Outdated Show resolved Hide resolved
@kevinrenskers
Don't sanitize span tags, not needed
93c51e7
@kevinrenskers
Merge branch 'master' into fix/1307-sanitze-span
c20efe8 
* master:
  fix: Crash in profiling logger (#1964)
  ref: Mark options.sdkInfo as deprecated (#1960)
  feat: Add extra app start span (#1952)
@kevinrenskers kevinrenskers changed the title fix: sanitize span data and tags fix: sanitize span data Jul 13, 2022
@kevinrenskers kevinrenskers merged commit 6ef0767 into master Jul 13, 2022
@kevinrenskers kevinrenskers deleted the fix/1307-sanitze-span branch July 13, 2022 08:24
@github-actions
Copy link

Fails
馃毇 Please consider adding a changelog entry for the next release.
`Instructions and example for changelog`$

Please add an entry to CHANGELOG.md` to the "Unreleased" section under the following heading:

To the changelog entry, please add a link to this PR (consider a more descriptive message):`

- sanitize span data(#1963)

If none of the above apply, you can opt out by adding _#skip-changelog_ to the PR description.

Generated by 馃毇 dangerJS against c20efe8

@kevinrenskers
Copy link
Contributor Author

Uh, it has a changelog entry. Weird.

kevinrenskers added a commit that referenced this pull request Jul 13, 2022
@kevinrenskers
Merge branch 'master' into fix/1824-read-free-memory-at-time-of-event
f05bd6f 
* master:
  fix: sanitize span data (#1963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipphofmann philipphofmann philipphofmann approved these changes

@brustolin brustolin Awaiting requested review from brustolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sanitize data of Span when serializing it
2 participants
@kevinrenskers @philipphofmann