Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sveltekit v2 #9851

Closed
5 tasks done
AbhiPrasad opened this issue Dec 14, 2023 · 4 comments
Closed
5 tasks done

Support Sveltekit v2 #9851

AbhiPrasad opened this issue Dec 14, 2023 · 4 comments
Assignees
Labels
Package: sveltekit Issues related to the Sentry SvelteKit SDK

Comments

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Dec 14, 2023

https://svelte.dev/blog/sveltekit-2

https://kit.svelte.dev/docs/migrating-to-sveltekit-2

Not necessary for initial kit 2.x support but nice to have eventually:

@AbhiPrasad AbhiPrasad added the Package: sveltekit Issues related to the Sentry SvelteKit SDK label Dec 14, 2023
@wesbos
Copy link

wesbos commented Dec 14, 2023

Our migration is here syntaxfm/website#1458 if you need us to test anything

@Lms24
Copy link
Member

Lms24 commented Dec 15, 2023

Added a few tasks to investigate from reading the migration guide and a few PRs

@Lms24
Copy link
Member

Lms24 commented Dec 15, 2023

Something to follow up on which hasn't yet landed - handle(Server)Load hooks: sveltejs/kit#11313

My first take: When this lands, we export handlers for it from our SDK but continue with auto instrumentation. In v9 we drop 1.x support, remove auto instrumentation and switch to exclusively instrumenting load functions via handle(Server)Load. If we adjust the wizard to add the handlers automatically at this point, I believe we should be good.

@Lms24
Copy link
Member

Lms24 commented Dec 19, 2023

Closing this issue as all necessary 2.x tasks were completed. We're going to release 7.89.0 in the next hours which will include all PRs linked above.

if you experience any after upgrading to sveltekit 2.x please let us know and open a new issue, thank you!

@Lms24 Lms24 closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: sveltekit Issues related to the Sentry SvelteKit SDK
Projects
Archived in project
Development

No branches or pull requests

3 participants