Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match old Transactions in Django #103

Closed
mitsuhiko opened this issue Oct 4, 2018 · 4 comments
Closed

Match old Transactions in Django #103

mitsuhiko opened this issue Oct 4, 2018 · 4 comments
Assignees

Comments

@mitsuhiko
Copy link
Member

mitsuhiko commented Oct 4, 2018

We only report the local function name in old transactions for django. David wants this to be the URL rule for Django. We should port the old resolver over to it (https://github.com/getsentry/raven-python/blob/03559bb05fd963e2be96372ae89fb0bce751d26d/raven/contrib/django/resolver.py).

@untitaker
Copy link
Member

A solution for this is implemented at #105. It adds a flag to enable the raven behavior but by default still uses the function names (because it's simpler and more consistent with what AWS Lambda, Flask and Sanic do)

@dcramer
Copy link
Member

dcramer commented Oct 4, 2018

@untitaker we need to enable it by default as we need the user experience to be on par or better than the current SDK. We can detect lambda and change the default based on that, but for normal Django users, which is the vast majority of Django users, the function name is a very poor experience.

@untitaker
Copy link
Member

We discussed this extensively in Slack and I think the agreement is that Django needs to behave like in Raven but we can still switch Flask to use endpoint instead of rule. Is that accurate?

@untitaker
Copy link
Member

Fixed by #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants