-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace sdkInfo
on iOS
#2530
Comments
Instead of this: resolve(@{
@"name": sentryOptions.sdkInfo.name,
@"version": sentryOptions.sdkInfo.version
}); do this resolve(@{
@"name": PrivateSentrySDKOnly.getSdkName,
@"version": PrivateSentrySDKOnly.getSdkVersionString
}); |
@brustolin that's possible but still not possible to add a new package. |
on RN iOS, the new package is added on the JS layer. sentry-react-native/src/js/integrations/sdkinfo.ts Lines 54 to 61 in 86821a4
via _nativeSdkInfo that is fetch from fetchNativeSdkInfo So this is possible with the #2530 (comment) alternative. |
Can we close this? |
This is not fixed yet, why would we close it? |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Description
sentry-react-native/ios/RNSentry.m
Lines 158 to 161 in 86821a4
sdkInfo is deprecated getsentry/sentry-cocoa#1960
PrivateSentrySDKOnly.getSdkName
and
PrivateSentrySDKOnly.getSdkVersionString
to retrieve the information
Cocoa issue
The text was updated successfully, but these errors were encountered: