Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sdkInfo on iOS #2530

Closed
krystofwoldrich opened this issue Oct 10, 2022 · 6 comments
Closed

Replace sdkInfo on iOS #2530

krystofwoldrich opened this issue Oct 10, 2022 · 6 comments

Comments

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Oct 10, 2022

Description

resolve(@{
@"name": sentryOptions.sdkInfo.name,
@"version": sentryOptions.sdkInfo.version
});

sdkInfo is deprecated getsentry/sentry-cocoa#1960

PrivateSentrySDKOnly.getSdkName
and
PrivateSentrySDKOnly.getSdkVersionString
to retrieve the information

Cocoa issue

@brustolin
Copy link
Contributor

Instead of this:

resolve(@{ 
     @"name": sentryOptions.sdkInfo.name, 
     @"version": sentryOptions.sdkInfo.version 
         }); 

do this

resolve(@{ 
     @"name": PrivateSentrySDKOnly.getSdkName, 
     @"version": PrivateSentrySDKOnly.getSdkVersionString 
         }); 

@marandaneto
Copy link
Contributor

@brustolin that's possible but still not possible to add a new package.
getsentry/sentry-dart#1056 (comment)

@marandaneto
Copy link
Contributor

on RN iOS, the new package is added on the JS layer.

event.sdk = {
...(event.sdk ?? {}),
...defaultSdkInfo,
packages: [
...((event.sdk && event.sdk.packages) || []),
...((this._nativeSdkInfo && [this._nativeSdkInfo]) || []),
...defaultSdkInfo.packages,
],

via _nativeSdkInfo that is fetch from fetchNativeSdkInfo
So this is possible with the #2530 (comment) alternative.

@brustolin
Copy link
Contributor

Can we close this?

@marandaneto
Copy link
Contributor

Can we close this?

This is not fixed yet, why would we close it?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants