Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(samples): Add Expo sample application #3427

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Nov 28, 2023

馃摙 Type of change

  • Enhancement

馃摐 Description

This PR adds an Expo application sample.

馃挕 Motivation and Context

馃挌 How did you test it?

Build with Expo Go

Screenshot 2023-11-28 at 15 03 27

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

馃敭 Next steps

#skip-changelog

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Messages
馃摉 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 馃毇 dangerJS against 43a70d6

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Android (legacy) Performance metrics 馃殌

Plain With Sentry Diff
Startup time 410.52 ms 427.66 ms 17.14 ms
Size 17.73 MiB 19.84 MiB 2.11 MiB

Copy link
Contributor

github-actions bot commented Nov 28, 2023

iOS (legacy) Performance metrics 馃殌

Plain With Sentry Diff
Startup time 1268.82 ms 1284.36 ms 15.54 ms
Size 2.36 MiB 2.87 MiB 521.03 KiB

Copy link
Contributor

Android (new) Performance metrics 馃殌

Plain With Sentry Diff
Startup time 393.90 ms 424.16 ms 30.27 ms
Size 7.15 MiB 8.11 MiB 987.03 KiB

@krystofwoldrich krystofwoldrich self-assigned this Nov 29, 2023
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should use some Sentry icons for the sample but that could be done on another issue. For now the PR is good for merging

@krystofwoldrich krystofwoldrich merged commit 3120e1d into expo Nov 29, 2023
51 of 54 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-expo-sample branch November 29, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants