Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expo): Add Expo Modules Integration #3466

Merged
merged 19 commits into from Jan 9, 2024
Merged

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Dec 13, 2023

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR adds expo native modules to detect when Sentry is running in Expo Go and mute native warning accordingly.

Next, it adds expo integration which uses the expo native modules to add device and os context to closer match events from production builds (those still have more information).

Before this PR out of the box debug logs:
290230634-9bee48e2-4d77-4c5f-83c6-1cfafe1ee32f

After this PR out of the box debug logs:
Screenshot 2024-01-09 at 17 30 15

Example of event from Expo Go after this PR:
Screenshot 2024-01-09 at 17 31 14

💡 Motivation and Context

💚 How did you test it?

sample app, unit/integration tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against eb26127

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 412.79 ms 438.96 ms 26.16 ms
Size 17.73 MiB 19.85 MiB 2.11 MiB

Baseline results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b 419.25 ms 458.81 ms 39.56 ms

App size

Revision Plain With Sentry Diff
bc4097b 17.73 MiB 19.84 MiB 2.11 MiB

Copy link
Contributor

github-actions bot commented Dec 13, 2023

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1204.26 ms 1211.87 ms 7.62 ms
Size 2.36 MiB 2.88 MiB 526.47 KiB

Baseline results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b+dirty 1223.67 ms 1230.08 ms 6.41 ms

App size

Revision Plain With Sentry Diff
bc4097b+dirty 2.36 MiB 2.88 MiB 524.45 KiB

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 348.71 ms 375.50 ms 26.79 ms
Size 7.15 MiB 8.11 MiB 990.92 KiB

Baseline results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b+dirty 378.29 ms 413.31 ms 35.01 ms

App size

Revision Plain With Sentry Diff
bc4097b+dirty 7.15 MiB 8.11 MiB 988.88 KiB

Base automatically changed from kw-add-dynamic-default-integrations to expo January 9, 2024 13:32
Copy link
Contributor

github-actions bot commented Jan 9, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1204.57 ms 1213.37 ms 8.80 ms
Size 2.92 MiB 3.44 MiB 530.75 KiB

Baseline results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b+dirty 1229.02 ms 1235.65 ms 6.63 ms

App size

Revision Plain With Sentry Diff
bc4097b+dirty 2.92 MiB 3.43 MiB 528.75 KiB

@krystofwoldrich krystofwoldrich marked this pull request as ready for review January 9, 2024 16:29
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich krystofwoldrich merged commit 4fb79c3 into expo Jan 9, 2024
67 of 69 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-add-expo-modules branch January 9, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants