feat: Add support of tracing::Span::record operation for sentry-tracing #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Sep 29, 2021
|
Can you run this through rustfmt real quick? That seems to be the only failure. |
Done |
Swatinem
approved these changes
Sep 30, 2021
sentry/tests/test_tracing.rs
Outdated
|
|
||
| assert_eq!(envelopes.len(), 1); | ||
|
|
||
| let envelope_item = envelopes[0].items().next().unwrap(); | ||
| let ref transaction = match envelope_item { | ||
| sentry::protocol::EnvelopeItem::Transaction(t) => t, | ||
| _ => { assert!(false); return; } | ||
| _ => { | ||
| assert!(false); |
There was a problem hiding this comment.
Since this is test code, you can as well panic!("expected only a transaction item");
As the panic diverges, you also don’t need the return/block afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR this code had no effect: