Differing logic between streaming and realtime

getsentry · Dec 11, 2012 · 392be82 · 392be82
1 parent 59573b0
commit 392be82
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/src/sentry/static/sentry/scripts/app.js b/src/sentry/static/sentry/scripts/app.js
@@ -7,6 +7,9 @@
     var BasePage = Backbone.View.extend({
 
         defaults: {
+            // can this view stream updates?
+            stream: false,
+            // should this view default to streaming updates?
             realtime: false
         },
 
@@ -63,6 +66,7 @@
                 id: id,
                 maxItems: 5,
                 pollUrl: uri,
+                stream: this.options.stream,
                 realtime: this.options.realtime,
                 model: app.Group
             });

diff --git a/src/sentry/static/sentry/scripts/views.js b/src/sentry/static/sentry/scripts/views.js
@@ -300,6 +300,7 @@
 
         defaults: {
             realtime: false,
+            stream: false,
             pollUrl: null,
             pollTime: 1000,
             tickTime: 100
@@ -328,7 +329,7 @@
                 return;
 
             var item = this.queue.pop();
-            if (this.options.realtime){
+            if (this.options.stream){
                 this.addMember(item);
             } else if (this.hasMember(item)) {
                 this.updateMember(item, {
@@ -340,7 +341,7 @@
         poll: function(){
             var data;
 
-            if (!this.options.realtime)
+            if (!this.options.realtime || !this.options.stream)
                 return window.setTimeout(this.poll, this.options.pollTime);
 
             data = app.utils.getQueryParams();

diff --git a/src/sentry/templates/sentry/groups/group_list.html b/src/sentry/templates/sentry/groups/group_list.html
@@ -147,7 +147,8 @@ <h6>{% trans filter.label %}</h6>
     $(function(){
         new app.StreamPage({
             groups: {{ event_list.paginator.objects|to_json:request|safe }},
-            realtime: {{ has_realtime|to_json|safe }}
+            stream: {{ has_realtime|to_json|safe }},
+            realtime: true
         });
     });
     </script>