fix(metrics): adjust regex to avoid exponential backtracking (#34881)

* fix(redos): adjust regex to avoid exponential backtracking * remove 3rd capture group Co-authored-by: Ahmed Etefy <ahmed.etefy12@gmail.com>
getsentry · May 24, 2022 · 5aa0283 · 5aa0283
1 parent ae49d44
commit 5aa0283
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/sentry/snuba/metrics/utils.py b/src/sentry/snuba/metrics/utils.py
@@ -59,8 +59,8 @@
 
 #: Max number of data points per time series:
 # ToDo modify this regex to only support the operations provided
-FIELD_REGEX = re.compile(r"^(\w+)\(((\w|\.|_|\:|\/|\@)+)\)$")
-TAG_REGEX = re.compile(r"^(\w|\.|_)+$")
+FIELD_REGEX = re.compile(r"^(\w+)\(([\w.:/@]+)\)$")
+TAG_REGEX = re.compile(r"^([\w.]+)$")
 
 #: A function that can be applied to a metric
 MetricOperationType = Literal[