Skip to content

Commit

Permalink
ref(ui): Remove capture exception for "Unknown event data" (#71460)
Browse files Browse the repository at this point in the history
We have been [capturing](#6338)
this issue for almost 7 years now and have not attempted to fix it so I
dont see a reason to continue capturing it. I have [created this
ticket](#71456) should someone
decide to pick it up in the future. This could be a metric but I don't
think there's a point as an increase of the metric doesn't mean
something is broken, it only indicates that the feature is missing.
  • Loading branch information
billyvg committed May 30, 2024
1 parent 7fc4f8e commit 833daae
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions static/app/components/events/interfaces/utils.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import * as Sentry from '@sentry/react';
import partition from 'lodash/partition';
import * as qs from 'query-string';

Expand Down Expand Up @@ -159,14 +158,11 @@ export function getCurlCommand(data: EntryRequest['data']) {
default:
if (typeof data.data === 'string') {
result += ' \\\n --data "' + escapeBashString(data.data) + '"';
} else if (Object.keys(data.data).length === 0) {
// Do nothing with empty object data.
} else {
Sentry.withScope(scope => {
scope.setExtra('data', data);
Sentry.captureException(new Error('Unknown event data'));
});
}
// It is common for `data.inferredContentType` to be
// "multipart/form-data" or "null", in which case, we do not attempt to
// serialize the `data.data` object as port of the cURL command.
// See https://github.com/getsentry/sentry/issues/71456
}
}

Expand Down

0 comments on commit 833daae

Please sign in to comment.