Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event ui): fixes JAVASCRIPT-2FR #6338

Merged
merged 3 commits into from
Oct 19, 2017
Merged

fix(event ui): fixes JAVASCRIPT-2FR #6338

merged 3 commits into from
Oct 19, 2017

Conversation

MaxBittker
Copy link
Contributor

@MaxBittker MaxBittker commented Oct 14, 2017

this isn't a big impact bug ( curl command is broken in some weird cases ) and I'm not sure what the best solution is because they're a variety of weird object shapes, (not sure why inferredContentType isn't being set)

but opening this to maybe ship as a solution or maybe talk about a better solution, could write a test too

@MaxBittker MaxBittker changed the title fix(event): fixes JAVASCRIPT-2FR fix(event ui): fixes JAVASCRIPT-2FR Oct 14, 2017
@evanpurkhiser
Copy link
Member

evanpurkhiser commented Oct 18, 2017

This is related to multipart/form-data data coming. Definitely down for a better solution, but need to think about it a bit.

@MaxBittker
Copy link
Contributor Author

thoughts on merging this to improve the behavior in the meantime?

@evanpurkhiser
Copy link
Member

Could you also capture the inferredContentType. Then good to merge

@MaxBittker
Copy link
Contributor Author

@evanpurkhiser re-review?

@MaxBittker MaxBittker merged commit 3c3370c into master Oct 19, 2017
@MaxBittker MaxBittker deleted the guard-curl-command branch October 19, 2017 17:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants