Skip to content

Commit

Permalink
feat(replay): Add new body size field to Network table (#46444)
Browse files Browse the repository at this point in the history
We moved the size field in the sdk in
getsentry/sentry-javascript#7589

Note that this field is for XHR/fetch and reflects the decoded body size
whereas the other `data.size` fields are *transfer* size (i.e. over the
network). We may want to consider changing to show decoded body size for
all, though that was only recently added to the SDK.
  • Loading branch information
billyvg committed Mar 30, 2023
1 parent 89c6efb commit be7a087
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion static/app/views/replays/detail/network/networkTableCell.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@ const NetworkTableCell = forwardRef<HTMLDivElement, Props>(
ref,
style,
};
const size = span.data.size ?? span.data.responseBodySize;

// `data.responseBodySize` is from SDK version 7.44-7.45
const size = span.data.size ?? span.data.response?.size ?? span.data.responseBodySize;

const renderFns = [
() => (
Expand Down

0 comments on commit be7a087

Please sign in to comment.