feat(replay): Add new body size field to Network table #46444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We moved the size field in the sdk in getsentry/sentry-javascript#7589 Note that this field is for XHR/fetch and reflects the decoded body size whereas the other `data.size` fields are *transfer* size (i.e. over the network). We may want to consider changing to show decoded body size for all, though that was only recently added to the SDK.
github-actions
bot
added
the
Scope: Frontend
eliashussary
approved these changes
Mar 30, 2023
JoshFerge
approved these changes
Mar 30, 2023
bruno-garcia
approved these changes
Mar 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved the size field in the sdk in getsentry/sentry-javascript#7589
Note that this field is for XHR/fetch and reflects the decoded body size whereas the other
data.sizefields are transfer size (i.e. over the network). We may want to consider changing to show decoded body size for all, though that was only recently added to the SDK.