Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Feedback] List Item CSS Tweaks #73628

Closed
Jesse-Box opened this issue Jul 2, 2024 · 2 comments · Fixed by #73983
Closed

[User Feedback] List Item CSS Tweaks #73628

Jesse-Box opened this issue Jul 2, 2024 · 2 comments · Fixed by #73983
Assignees

Comments

@Jesse-Box
Copy link
Contributor

Jesse-Box commented Jul 2, 2024

Problems

  1. Too much ornamentation for indicating when a piece of user feedback is selected.
  2. The unread dots are inconsistent with how the rest of the frontend deals with “unseen” stuff (instead unread email address should be bold, normal font size when it is read)
  3. Vertical spacing between email address and feedback preview is awkward when compared with the feedback preview and the footer information (project name + icons)
  4. Font sizes of the feedback preview and project name are too big

Image

Solution

See Figma Library

Component in Isolation
Image

Component in Composition
Image

@michellewzhang
Copy link
Member

michellewzhang commented Jul 8, 2024

@Jesse-Box what did you mean by "Vertical spacing between email address and feedback preview is awkward when compared with the feedback preview and the footer information (project name + icons)"?

With the updated font sizes, the UI now looks like this - the name part is 14px, all other text is 12px.

SCR-20240708-niqg

We leave room at the bottom of 1-line feedback previews to account for the space that 2-line previews take up; otherwise the heights of the feedback cards wouldn't all be consistent. Did you have a different spacing in mind? (currently the gap is 8px which is what it looks to be in the figma

SCR-20240708-njbp

Unrelated to the spacing -- it's also significantly harder to tell which feedback is unread vs read after getting rid of the purple dot

pr here: #73983

@Jesse-Box
Copy link
Contributor Author

what did you mean by "Vertical spacing between email address and feedback preview is awkward when compared with the feedback preview and the footer information (project name + icons)"?

I DM'd you a rewatch video, since it contains customer data. Hopefully, that explains myself as well!

We leave room at the bottom of 1-line feedback previews to account for the space that 2-line previews take up; otherwise the heights of the feedback cards wouldn't all be consistent.

Here are my thoughts on this point right now. In practice, implementing a static height for the feedback preview results in the footer information being visually linked to the subsequent feedback item, rather than the feedback item it is actually linked to. Ideally, we can preview up to two lines of feedback, but if their feedback is short, the feedback preview height is reduced to compensate. Alternatively, we only show one line of feedback.

Unrelated to the spacing -- it's also significantly harder to tell which feedback is unread vs read after getting rid of the purple dot.

I heard this from Ryan as well, so maybe this was a stupid idea… Can you re-introduce the dot? Sorry about that!

@michellewzhang michellewzhang self-assigned this Jul 11, 2024
priscilawebdev pushed a commit that referenced this issue Jul 13, 2024
- closes #73628
- adjust uf linked card styles so they align with the [figma
designs](https://www.figma.com/design/DIlstrVINTYNJad4BS0f9L/Assets%3A-User-Feedback-Product-UI?node-id=2-2&t=30176FG9PWWaw0zS-0)

major changes:
- entire purple border when item selected (add back in card spacing)
- better spacing between grid
- updated font sizes
- we only show 1 line of preview now to have more consistent spacing

| before | after | figma |
| --- | --- | --- |
| <img width="420" alt="SCR-20240711-mhzt"
src="https://github.com/getsentry/sentry/assets/56095982/3f2f9549-58ec-4bbb-a5b2-43e3047e8da5">|
<img width="406" alt="SCR-20240711-mhui"
src="https://github.com/getsentry/sentry/assets/56095982/f8a2df8d-ddf4-4303-8558-139e8be4c83b">
| <img width="426" alt="SCR-20240711-mime"
src="https://github.com/getsentry/sentry/assets/56095982/05e022fb-c44a-4b02-b906-5ceb1059eff1">
|



before:


https://github.com/getsentry/sentry/assets/56095982/f325a915-762b-4353-b710-ae3e452daed2

after:


https://github.com/getsentry/sentry/assets/56095982/b6c3caff-2fa7-42a2-93fa-e09a0fa9016f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants