style(feedback): adjust some feedback list css #73983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
michellewzhang
force-pushed
the
mz/feedback-css
branch
from
00dcdc4
to
946b7a7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73983 +/- ##
==========================================
- Coverage 78.11% 78.07% -0.05%
==========================================
Files 6656 6669 +13
Lines 297664 298371 +707
Branches 51223 51371 +148
==========================================
+ Hits 232535 232967 +432
- Misses 58860 59069 +209
- Partials 6269 6335 +66
|
ryan953
approved these changes
Jul 11, 2024
Jesse-Box
approved these changes
Jul 12, 2024
HEHHEHE my fav thing to test with @c298lee |
priscilawebdev
pushed a commit
that referenced
this pull request
Jul 13, 2024
- closes #73628 - adjust uf linked card styles so they align with the [figma designs](https://www.figma.com/design/DIlstrVINTYNJad4BS0f9L/Assets%3A-User-Feedback-Product-UI?node-id=2-2&t=30176FG9PWWaw0zS-0) major changes: - entire purple border when item selected (add back in card spacing) - better spacing between grid - updated font sizes - we only show 1 line of preview now to have more consistent spacing | before | after | figma | | --- | --- | --- | | <img width="420" alt="SCR-20240711-mhzt" src="https://github.com/getsentry/sentry/assets/56095982/3f2f9549-58ec-4bbb-a5b2-43e3047e8da5">| <img width="406" alt="SCR-20240711-mhui" src="https://github.com/getsentry/sentry/assets/56095982/f8a2df8d-ddf4-4303-8558-139e8be4c83b"> | <img width="426" alt="SCR-20240711-mime" src="https://github.com/getsentry/sentry/assets/56095982/05e022fb-c44a-4b02-b906-5ceb1059eff1"> | before: https://github.com/getsentry/sentry/assets/56095982/f325a915-762b-4353-b710-ae3e452daed2 after: https://github.com/getsentry/sentry/assets/56095982/b6c3caff-2fa7-42a2-93fa-e09a0fa9016f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
major changes:
before:
Screen.Recording.2024-07-11.at.1.46.01.PM.mov
after:
trim_after.mov