feat(auth): Allow superusers to bypass server rendered auth page #10349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For inactive superusers, bypass server rendered login page and allow React frontend to handle the route. This means if you are trying to access an org you do not have access to, React will continue to perform the API requests at that route. This will result in a 403 and open the sudo login modal.
macqueen
approved these changes
Oct 30, 2018
| def handle_auth_required(self, request, *args, **kwargs): | ||
| # If user is a superuser (but not active, because otherwise this method would never be called) | ||
| # Then allow client to handle the route and respond to any API request errors | ||
| if request.user.is_superuser: |
There was a problem hiding this comment.
was going to say that i think it's possible for request.user to be anonymous here, but apparently is_superuser will always be false in that case https://docs.djangoproject.com/en/1.7/ref/contrib/auth/#anonymous-users so this should be fine
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For inactive superusers, bypass server rendered login page and allow React frontend
to handle the route. This means if you are trying to access an org you do not have
access to, React will continue to perform the API requests at that route. This will
result in a 403 and open the sudo login modal.