Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(discover): issue.id returns short id instead of internal id #10633

Merged
merged 1 commit into from
Nov 16, 2018
Merged

feat(discover): issue.id returns short id instead of internal id #10633

merged 1 commit into from
Nov 16, 2018

Conversation

lynnagara
Copy link
Member

Since this field isn't in Snuba, prevent orderby and conditions on this field

@lynnagara
feat(discover): issue.id returns external short id instead of interna…
02642d3 
…l id

Since this field isn't in Snuba, prevent orderby and conditions on this field
@lynnagara lynnagara requested review from benvinegar and a team November 16, 2018 18:57
benvinegar
benvinegar approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@benvinegar benvinegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I legitimately read through the Python, and nothing sticks out for me, caveated that I'm not super familiar with these files.

@lynnagara lynnagara merged commit a4ce1e5 into master Nov 16, 2018
@lynnagara lynnagara deleted the feat/issue-id branch November 16, 2018 21:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benvinegar benvinegar benvinegar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lynnagara @benvinegar