[feat] Enable loader interface #12644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
approved these changes
Apr 4, 2019
|
@billyvg You can ask matt, we have some stats in fastly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
@sentry/browser5.0.5organizations:js-loaderfeature flag and with that enable this interface:This helps people to decide which version of the SDK they want to load when using the loader.
The logic of this was already in place and the way it works is that from now on if you create a new project by default you will get version
5.xof the browser SDK.All projects before that will stay on
4.xand people need to opt-in / change the setting to receive the new SDK.This is here to not break peoples sites when using the loader. As I said, the functionally was there since the loader existed we just hid the interface since there was no major bump before.
ref: getsentry/sentry-javascript#1965
I've added @benvinegar since this is a new setting for people to concern, once this is ready to merge I will inform Support on this change.