ref(ts): Refactor DateTime component #14235
Conversation
| @@ -5,7 +5,16 @@ import _ from 'lodash'; | |||
|
|
|||
| import ConfigStore from 'app/stores/configStore'; | |||
|
|
|||
| class DateTime extends React.Component { | |||
| type Props = { | |||
| date: any; | |||
There was a problem hiding this comment.
Even though the propTypes is any, we should be a bit more specific on the type. It looks like it can be either: 1) string, 2) number (e.g. unix timestamp), or 3) Date object
There was a problem hiding this comment.
Let's use moment.MomentInput. I suspect the coercedDate line might be unnecessary and can be deleted as moment can handle string and unix time as input.
MeredithAnya
force-pushed
the
typescript/datetime-component
branch
2 times, most recently
from
eaa3e2c
to
af31c2d
Compare
| @@ -8,15 +8,15 @@ type Options = { | |||
| type Device = { | |||
| Type: string; | |||
| Generation: string; | |||
| ANumber: string[]; | |||
There was a problem hiding this comment.
Are these changes supposed to be in this PR?
There was a problem hiding this comment.
yeah I just thought I'd add them in here instead of doin a separate pr - can always pull them out if thats better
There was a problem hiding this comment.
Looks like a totally separate change right?
There was a problem hiding this comment.
It's not related to the component in this PR and is not covered by the description, pulling it out separately is better
There was a problem hiding this comment.
cool - pulled it out and put it in #14267
MeredithAnya
force-pushed
the
typescript/datetime-component
branch
from
af31c2d
to
c6b9dfe
Compare
No description provided.