Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(js) remove lodash/get #16614

Merged
merged 21 commits into from
Apr 1, 2020
Merged

ref(js) remove lodash/get #16614

merged 21 commits into from
Apr 1, 2020

Conversation

jeffkwoh
Copy link
Contributor

@jeffkwoh jeffkwoh commented Jan 24, 2020 •
edited
Loading

Frontend TSC notioned to remove lodash/get in preference of optional chaining and null coalescence.

@jeffkwoh jeffkwoh mentioned this pull request Jan 24, 2020
Closed
@jeffkwoh jeffkwoh requested a review from dashed January 24, 2020 00:02
@jeffkwoh jeffkwoh added the WIP label Jan 24, 2020
@jeffkwoh @billyvg
Add no lodash/get to es-lint
89c36fb
@jeffkwoh @billyvg
Remove lodash/get from contexts.jsx
775b896
@jeffkwoh @billyvg
Remove lodash/get from utils
db8353b
@jeffkwoh @billyvg
Remove lodash/get from permissionSelection
6431112
@jeffkwoh @billyvg
Remove lodash/get from header.tsx
305ef2f
@jeffkwoh @billyvg
Remove lodash/get from sentryApplicationDetails.tsx
82013b6
@jeffkwoh @billyvg
Remove lodash/get from modal.jsx
c442a66
@jeffkwoh @billyvg
Remove lodash/get from navigation.jsx
0fa2c29
@jeffkwoh @billyvg
Remove lodash/get from stacktraceContent.jsx
d3744d4
@jeffkwoh @billyvg
Remove lodash/get from app.jsx
545b5c1
@jeffkwoh @billyvg
Remove lodash/get from sentryAppExternalInstallation.tsx
1f82c52
@jeffkwoh @billyvg
Remove lodash/get from api.tsx
97c7f9b
@jeffkwoh @billyvg
Remove lodash/get from debugmeta.jsx
11f2b18
@jeffkwoh @billyvg
Partially remove lodash/get from traceView.tsx
484a0ab
@jeffkwoh @billyvg
Remove lodash/get from spanTree.tsx
bdbf272
@jeffkwoh @billyvg
Remove lodash/get from formatters.tsx
a5015b4
@jeffkwoh @billyvg
Remove lodash/get from spanBar.tsx
34e8244
@jeffkwoh @billyvg
Remove lodash/get from spanDetail.tsx
c6cffe2
@jeffkwoh @billyvg
Add TODO
6bf8228
@jeffkwoh @billyvg
Update eslintrc message
640aa93
@billyvg billyvg removed the WIP label Mar 26, 2020
@billyvg billyvg requested a review from a team March 27, 2020 16:35
dashed
dashed approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@billyvg billyvg mentioned this pull request Mar 27, 2020
Merged
@billyvg billyvg merged commit 5a7c73f into master Apr 1, 2020
@billyvg billyvg deleted the ref/removeLodash/get branch April 1, 2020 17:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dashed dashed dashed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffkwoh @dashed @billyvg