Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(apm): Polish operation breakdown #20550

Merged
merged 1 commit into from
Sep 2, 2020
Merged

ref(apm): Polish operation breakdown #20550

merged 1 commit into from
Sep 2, 2020

Conversation

dashed
Copy link
Member

@dashed dashed commented Sep 2, 2020

  • If there is an "Other" category, do not add a colour dot.
  • Rename "Ops Breakdown" to "Operation Breakdown". We use the terminology "Operation" instead of "Ops" in various parts of the product when referring to the span operation name.

Before:

Screen Shot 2020-09-02 at 5 41 13 AM

After:

Screen Shot 2020-09-02 at 5 41 28 AM

@dashed dashed requested a review from a team September 2, 2020 09:45
@dashed dashed self-assigned this Sep 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2020

size-limit report

Path Size
public/app.js 230.94 KB (0%)
public/vendor.js 444.49 KB (0%)

@dashed dashed merged commit 6433ec7 into master Sep 2, 2020
@dashed dashed deleted the apm-polish-operation-breakdown branch September 2, 2020 17:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markstory markstory markstory approved these changes

@Zylphrex Zylphrex Zylphrex approved these changes

Assignees

@dashed dashed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dashed @markstory @Zylphrex