Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flag): Add trends specific feature flag #20711

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Sep 10, 2020

Summary

This will allow us to add more than just internal teams into trends, replacing the existing 'internal-catchall' guards

This will allow us to add more than just internal teams into trends, replacing the existing 'internal-catchall' guards
@k-fish k-fish requested a review from a team as a code owner September 10, 2020 17:13
@vercel
Copy link

vercel bot commented Sep 10, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

@github-actions
Copy link
Contributor

size-limit report

Path Size
public/app.js 230.85 KB (0%)
public/vendor.js 444.51 KB (0%)

Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You'll also need a feature handler in getsentry.

@k-fish k-fish merged commit ae89073 into master Sep 10, 2020
@k-fish k-fish deleted the feat/flag-trends-feature branch September 10, 2020 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants