Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): Unflag metric alerts time selector #20851

Merged
merged 2 commits into from Sep 18, 2020

Conversation

scttcper
Copy link
Member

Makes the time picker dropdown available to everyone, the bucketing test will still be hidden.

also fixes the divide by 0 issue in the janky bucketing test

image

@scttcper scttcper requested a review from a team September 18, 2020 00:09
@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2020

size-limit report

Path Size
public/app.js 234.91 KB (0%)
public/vendor.js 444.47 KB (0%)

Copy link
Member

@davidenwang davidenwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@iProgramStuff iProgramStuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :-)

@scttcper scttcper merged commit f1b7c3d into master Sep 18, 2020
@scttcper scttcper deleted the scttcper/unflag-metric-timewindo branch September 18, 2020 18:12
jan-auer added a commit that referenced this pull request Sep 21, 2020
* master: (56 commits)
  fix(releases): Use sql formatting instead of string formatting for list of ids (#20875)
  ref(rediscluster): Reset cluster nodes and retry on ClusterError (#20859)
  ref(eventattachment): Use the local type column of EventAttachment in queries (#20785)
  remove message from skip fields (#20870)
  fix(py3): Fix tests in test_organization_group_index (#20848)
  check if highight children is proper string (#20867)
  fix(ui) Fix alignment of ? icons in headings (#20865)
  feat(alerts): Unflag metric alerts time selector (#20851)
  change to most regressed (#20861)
  fix(py3): Fix test_eventstream tests (#20850)
  fix(py3): Fix OrganizationEventsV2EndpointTest.test_sort_invalid (#20846)
  fix(py3): Fix test_unmerge tests, and unsafe uses of dict.values() (#20853)
  fix(py3): Fix test_optimized_aggregates test (#20852)
  fix(tests) Add discover integration tests to snuba makefile (#20840)
  feat(relay): Add public_key to RelayUsage (#20836)
  feat(similarity): Ability to diff grouping components (#20813)
  feat: Remove releases v2 flag checks (#20777)
  feat(workflow): Dynamic counts chart buckets and no filtered stats except issue list (#20824)
  adds x frame options back (#20844)
  fix(py3): Fix test_organization_events_stats tests in py3 (#20833)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants