Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(py3): Fix test_unmerge tests, and unsafe uses of dict.values() #20853

Merged
merged 1 commit into from Sep 18, 2020
Merged

fix(py3): Fix test_unmerge tests, and unsafe uses of dict.values() #20853

merged 1 commit into from Sep 18, 2020

Commits on Sep 18, 2020

  1. fix(py3): Fix test_unmerge tests, and unsafe uses of dict.values() 

    The issues here were:
 - Indexing into `dict.values()`, which fails in py3 since it's a view. Audited the rest of the
   codebase to find other unsafe uses.
 - md5 not being passed bytes
    @wedamija
    wedamija committed Sep 18, 2020
    Copy the full SHA
    aa7530f View commit details
    Browse the repository at this point in the history